Closed aryanbhosale closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.94%. Comparing base (
ed61958
) to head (ed964d9
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @aryanbhosale. Thanks for this. It would be great if you could use the values in the example that @roshnaeem originally: OPEN_METEO_MODELS=ncep_gfs013 OPEN_METEO_VARIABLES=temperature_2m,precipitation,cloud_cover OPEN_METEO_MAX_AGE_DAYS=3 OPEN_METEO_REPEAT_INTERVAL=5 OPEN_METEO_CONCURRENT=4
Such that OPEN_METEO_MODELS = models separated by commas
becomes OPEN_METEO_MODELS = models separated by commas e.g: ncep_gfs013
Hi @aryanbhosale. Thanks for this. It would be great if you could use the values in the example that @roshnaeem originally: OPEN_METEO_MODELS=ncep_gfs013 OPEN_METEO_VARIABLES=temperature_2m,precipitation,cloud_cover OPEN_METEO_MAX_AGE_DAYS=3 OPEN_METEO_REPEAT_INTERVAL=5 OPEN_METEO_CONCURRENT=4
Such that OPEN_METEO_MODELS = models separated by commas
becomes OPEN_METEO_MODELS = models separated by commas e.g: ncep_gfs013
Hi @zakwatts , thank you for the review, I've updated the code in my latest commit
Also could you add some information about what the Open Meteo credentials are for? #84 as outlined in this PR? Just to avoid confusion from anyone looking at it thinking that it might be necessary to set these in order to create forecasts
Also could you add some information about what the Open Meteo credentials are for? #84 as outlined in this PR? Just to avoid confusion from anyone looking at it thinking that it might be necessary to set these in order to create forecasts
does the new commit cover it?
@all-contributors please add @aryanbhosale for code
@zakwatts
I've put up a pull request to add @aryanbhosale! :tada:
Pull Request
Description
removed .env, added .env to .gitignore, added docker setup environment variables to .env.example to enhance security and privacy
Checklist: