openclimatefix / open-source-quartz-solar-forecast

Open Source Solar Site Level Forecast
MIT License
60 stars 51 forks source link

removed .env, added .env to .gitignore, added docker setup environment variables to .env.example #94

Closed aryanbhosale closed 6 months ago

aryanbhosale commented 6 months ago

Pull Request

Description

removed .env, added .env to .gitignore, added docker setup environment variables to .env.example to enhance security and privacy

Checklist:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.94%. Comparing base (ed61958) to head (ed964d9). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #94 +/- ## ======================================= Coverage 79.94% 79.94% ======================================= Files 12 12 Lines 354 354 ======================================= Hits 283 283 Misses 71 71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zakwatts commented 6 months ago

Hi @aryanbhosale. Thanks for this. It would be great if you could use the values in the example that @roshnaeem originally: OPEN_METEO_MODELS=ncep_gfs013 OPEN_METEO_VARIABLES=temperature_2m,precipitation,cloud_cover OPEN_METEO_MAX_AGE_DAYS=3 OPEN_METEO_REPEAT_INTERVAL=5 OPEN_METEO_CONCURRENT=4

Such that OPEN_METEO_MODELS = models separated by commas

becomes OPEN_METEO_MODELS = models separated by commas e.g: ncep_gfs013

aryanbhosale commented 6 months ago

Hi @aryanbhosale. Thanks for this. It would be great if you could use the values in the example that @roshnaeem originally: OPEN_METEO_MODELS=ncep_gfs013 OPEN_METEO_VARIABLES=temperature_2m,precipitation,cloud_cover OPEN_METEO_MAX_AGE_DAYS=3 OPEN_METEO_REPEAT_INTERVAL=5 OPEN_METEO_CONCURRENT=4

Such that OPEN_METEO_MODELS = models separated by commas

becomes OPEN_METEO_MODELS = models separated by commas e.g: ncep_gfs013

Hi @zakwatts , thank you for the review, I've updated the code in my latest commit

zakwatts commented 6 months ago

Also could you add some information about what the Open Meteo credentials are for? #84 as outlined in this PR? Just to avoid confusion from anyone looking at it thinking that it might be necessary to set these in order to create forecasts

aryanbhosale commented 6 months ago

Also could you add some information about what the Open Meteo credentials are for? #84 as outlined in this PR? Just to avoid confusion from anyone looking at it thinking that it might be necessary to set these in order to create forecasts

does the new commit cover it?

zakwatts commented 6 months ago

@all-contributors please add @aryanbhosale for code

allcontributors[bot] commented 6 months ago

@zakwatts

I've put up a pull request to add @aryanbhosale! :tada: