openclimatefix / PVConsumer

Consumer PV data from various sources
Apache License 2.0
3 stars 1 forks source link

The tests fail on a clean install #51

Closed simlmx closed 1 year ago

simlmx commented 1 year ago

Description

The tests fail on branch main with a clean setup.

How To Reproduce

  1. Clone the code
  2. Follow the readme instructions to run the tests

Investigation

Here are some things making it break:

Recommendations

CC @peterdudfield

peterdudfield commented 1 year ago

Thats bad, sorry about this. I hate it when things are broken like this

peterdudfield commented 1 year ago

Let me have a quick look to see what is failling

peterdudfield commented 1 year ago

Yea sorry it should have been pinned to a version

peterdudfield commented 1 year ago

I could solved it, but my feeling is the upgrade due to #52 should also be able to solve it. Or @simlmx would you like me to sovle it first, to make the new work easier

peterdudfield commented 1 year ago

btw pvsite_datamodel=0.1.7 should make it work

simlmx commented 1 year ago

I don't think I have tried 0.1.7 but 0.1.6 did not work (I must've rounded to the wrong version when trying to find which should work)!

But some tests assume some local environment (a $HOME/.pvoutput.yml file) and if I'm not mistaken some call an external API, which is a very bad idea. Also there were some requests errors that could be due to change in the requests library, I'm not sure.

peterdudfield commented 1 year ago

i looked at the last github actions to be successful, and i think ti was 0.1.7

simlmx commented 1 year ago

This was mostly fixed in #53 and #55.

We decided to keep the tests calling external APIs for now, which are still broken but I opened a new ticket just for those: #54.