search

openclimatefix / PVConsumer

Consumer PV data from various sources
Apache License 2.0
3 stars 1 forks source link

Sentry update to the code #76

Closed ADIMANV closed 2 months ago

ADIMANV commented 2 months ago

Pull Request

Description

Minor Update to the code which adds Sentry for a better error detection Stems from the PR: https://github.com/openclimatefix/ocf-infrastructure/issues/540

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.92%. Comparing base (fdb2259) to head (e40878a). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== - Coverage 96.44% 91.92% -4.52% ========================================== Files 6 6 Lines 281 285 +4 ========================================== - Hits 271 262 -9 - Misses 10 23 +13 ``` | [Flag](https://app.codecov.io/gh/openclimatefix/PVConsumer/pull/76/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openclimatefix) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/openclimatefix/PVConsumer/pull/76/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openclimatefix) | `91.92% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openclimatefix#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

peterdudfield commented 2 months ago

This looks good,

Could you also run poetry lock update or poetry update lock` - i cant remember which one it its