search

openclimatefix / PVNet-summation

This project is used for training a model to sum the GSP predictions of PVNet into a national estimate
MIT License
0 stars 0 forks source link

Remove properties #16

Closed dfulu closed 8 months ago

dfulu commented 8 months ago

Pull Request

Description

Similar to openclimatefix/PVNet#149

I've been having trouble instantiating models with hydra because of these properties. It is simpler to remove them and replace them with attributes instead.

Also removing some requirements which aren't used by the summation model

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.53%. Comparing base (714ff80) to head (9eab67b).

Files Patch % Lines
pvnet_summation/models/base_model.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16 +/- ## ========================================== + Coverage 59.36% 59.53% +0.17% ========================================== Files 6 6 Lines 470 472 +2 ========================================== + Hits 279 281 +2 Misses 191 191 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.