Closed 14Richa closed 3 months ago
This is a good start! Thanks for this work. Its getting closer to what I was thinking for the image downloading. Mostly just some comments related to what was mentioned in #222, and some more simple checks to speed up the downloading and not download the same data multiple times.
Thanks for the comments @jacobbieker! I've addressed most of them and incorporated your suggestions. I've created a main DownloadManager class combining functionalities for EUMETSAT and GOES downloads. Also, I'm thinking of changing the filename from eumetsat.py
to download_manager.py
for better clarity. What do you think? Do you have any other suggestions for the filename?
This is a good start! Thanks for this work. Its getting closer to what I was thinking for the image downloading. Mostly just some comments related to what was mentioned in #222, and some more simple checks to speed up the downloading and not download the same data multiple times.
Thanks for the comments @jacobbieker! I've addressed most of them and incorporated your suggestions. I've created a main DownloadManager class combining functionalities for EUMETSAT and GOES downloads. Also, I'm thinking of changing the filename from
eumetsat.py
todownload_manager.py
for better clarity. What do you think? Do you have any other suggestions for the filename?
Yeah, making it download_manager.py
is better, and moving the EUMETSATDownloadManager
to a eumetsat.py
file.
Nice improvements! This kind of design is good, especially for being able to add more providers in the future. There will need to be some more changes to the code, as
DownloadManager
now doesn't do what it did before. So if you could update the other calls to be theEUMETSATDownloadManager
that would be great! And might be the last changes for this PR I think.
Thanks for the feedback @jacobbieker ! I have updated the code as per your suggestion, changing the other calls to use EUMETSATDownloadManager
.
Also, there will need to be a few updates to the tests, as they have changed in #229
Hey @jacobbieker, both of my tests are running successfully. Can we merge this PR now?
@all-contributors please add @14Richa for code
@peterdudfield
I've put up a pull request to add @14Richa! :tada:
Pull Request
Description
This pull request adds a script for downloading GOES data. The script uses the
GOES2GO
library to download data for a specified time range and product. It includes functionality to save the downloaded data to a specified directory and log any errors encountered during the download process.Fixes #222
Checklist: