openclimatefix / Satip

Satip contains the code necessary for retrieving, transforming and storing EUMETSAT data
https://satip.readthedocs.io/
MIT License
41 stars 29 forks source link

Move channels constants from utils.py to constants.py #241

Closed JasonFengGit closed 3 months ago

JasonFengGit commented 3 months ago

Pull Request

Description

Fixes #87

Moved channels lists and scalers from utils.py to constants.py

How Has This Been Tested?

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

peterdudfield commented 3 months ago

Do you mind @JasonFengGit merging the latest release into your branch, this will mean that test will then run automatically

JasonFengGit commented 3 months ago

Hi @peterdudfield, I just merged the latest release and I ran the tests on my local machine. tests on my machine says "19 passed, 2 skipped, 107 warnings in 2072.94s (0:34:32)".

JasonFengGit commented 3 months ago

Hi @peterdudfield @jacobbieker, the auto tests failed because there is no API keys Environmental Variables, is there anything I can do to resolve this?

JasonFengGit commented 3 months ago

Thanks!

peterdudfield commented 3 months ago

@all-contributors please add @JasonFengGit for code

allcontributors[bot] commented 3 months ago

@peterdudfield

I've put up a pull request to add @JasonFengGit! :tada: