openclimatefix / graph_weather

PyTorch implementation of Ryan Keisler's 2022 "Forecasting Global Weather with Graph Neural Networks" paper (https://arxiv.org/abs/2202.07575)
MIT License
188 stars 47 forks source link

Undersurface values #30

Open byphilipp opened 2 years ago

byphilipp commented 2 years ago

Some values on p-levels coresponds to the virtual values under Earth surface

May be we dont takes into account this values in loss function ?

jacobbieker commented 2 years ago

Yeah, in the original paper, the author didn't mask pressure levels that go underground, so I'll probably leave it as is here, but could add an option for adding a mask I guess in the NormalizeMSELoss