Hey @peterdudfield. So, I've created this PR more as a WIP where I can push new commits based on your feedback, rather than a final submission, and we can work more collaboratively to make the changes you're after.
I've made what I think are the changes you're after to the client.py module in the dummydb folder.
Could you review and let me know if this is in-line with what you're after, please? Please ignore the changes I've made to the relative imports and also setting the PTYHONPATH. I've only made those changes to create a 'test environment' of sorts on my local machine. I was thinking that if we arrive at the solution you're after, I can revert those changes in the final commit.
How Has This Been Tested?
If the changes described above are what you're after, could you please advise me on the below error I'm getting when testing? Looking at the stack trace, running the dummy client.py module daisy chains to 3 __init__.py files to ultimately run the actual client.py module which is attempting to connect to the DB:
Could you provide me some guidance on what changes I should make to prevent this module running? I'm reluctant to make any significant changes to your codebase given that we're only looking to make a small alteration. I don't want to alter too much, so if you could advise me on what steps I should follow such that we can make the necessary changes without altering too much of the existing repo structure.
Of course, all the above is moot if the changes that I've made are not actually correct! So, please do let me know and I'll make the required changes :). Thank you!
[x] Yes
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Doesn't affect data processing. But, if successful, will allow a dummy DB to be created.
Pull Request
Issue #354
Description
client.py
module in thedummydb
folder.How Has This Been Tested?
client.py
module daisy chains to 3__init__.py
files to ultimately run the actualclient.py
module which is attempting to connect to the DB: Could you provide me some guidance on what changes I should make to prevent this module running? I'm reluctant to make any significant changes to your codebase given that we're only looking to make a small alteration. I don't want to alter too much, so if you could advise me on what steps I should follow such that we can make the necessary changes without altering too much of the existing repo structure.Of course, all the above is moot if the changes that I've made are not actually correct! So, please do let me know and I'll make the required changes :). Thank you!
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check? Doesn't affect data processing. But, if successful, will allow a dummy DB to be created.
Checklist: