openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database
MIT License
1 stars 4 forks source link

pvsite-datamodel integration & fake forecasts #1

Closed confusedmatrix closed 7 months ago

confusedmatrix commented 8 months ago

Pull Request

Description

N.B This work is dependent on https://github.com/openclimatefix/pv-site-datamodel/pull/97

Still TODO:

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

peterdudfield commented 8 months ago

To get the tests running, I think we need a later version of this github reusable workflow - https://github.com/openclimatefix/india-forecast-app/blob/main/.github/workflows/ci.yml#L37

confusedmatrix commented 8 months ago

To get the tests running, I think we need a later version of this github reusable workflow - https://github.com/openclimatefix/india-forecast-app/blob/main/.github/workflows/ci.yml#L37

This line refers to the docker-release reusable workflow which I believe is already pinned to the latest version v1.2.0

The github action doesn't currently run as the github action secrets aren't yet set. Would you be able to set the following secrets for me please?

DOCKERHUB_USERNAME DOCKERHUB_TOKEN PAT_TOKEN

peterdudfield commented 8 months ago

secrets added, add 1.8.1 is the latest

codecov[bot] commented 8 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella: