openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database

MIT License

2 stars 4 forks source link

add pydantic model for ml models #101

Closed peterdudfield closed 2 months ago

peterdudfield commented 2 months ago

Pull Request

Description

put model configs in yaml
add ml model pydantic model
loop thorugh models when running app

This allows us to run multiple ml models if we want too

How Has This Been Tested?

CI tests

[ ] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

Sukh-P commented 2 months ago

Also wondering if https://github.com/openclimatefix/uk-pvnet-app could benefit from a similar change, although may be slightly more complex with the config/setup there

peterdudfield commented 2 months ago

Also wondering if https://github.com/openclimatefix/uk-pvnet-app could benefit from a similar change, although may be slightly more complex with the config/setup there

yep - https://github.com/openclimatefix/uk-pvnet-app