openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database
MIT License
1 stars 4 forks source link

India Todo list #2

Closed peterdudfield closed 6 months ago

peterdudfield commented 8 months ago

Data Consumer

Info: Collect National wind and PV data from https://sldc.rajasthan.gov.in/rrvpnl/rajasthan-overview

https://github.com/openclimatefix/ruvnl-consumer-app

Forecast App

Use pvsite-Datamodel

API

Email

Infrastructure

jacobbieker commented 8 months ago

Should this be imported into datapipes, like the current nowcasting_datamodel is? I'm primarily asking as I can't add India PV inputs to datapipes without changing nowcasting_datamodel to take more labels: https://github.com/openclimatefix/nowcasting_datamodel/blob/8fcc3ae61b50ca30815b910d9db2621ae6b2c33e/nowcasting_datamodel/models/pv.py#L20-L22

And I'm not sure whether that should be done here, or in the other one

jacobbieker commented 8 months ago

And if so, and nowcasting_datamodels is UK-specific, we might want to change how we name it

peterdudfield commented 8 months ago

Interesting, thanks @jacobbieker for flagging this.

Nowcasting_datamodel has a lot of GSP specific stuff in it, so I would be tempted to actually use pv-site-datamodel as a better repo to start with.

I'm a little bit suprised you need nowcasting_datamodel for ingesting PV India data? Can you share the code where this is happening? Is this for validating the data?

jacobbieker commented 8 months ago

Its this check here: https://github.com/openclimatefix/ocf_datapipes/blob/e86aabfe62f52a0bf18bd0a8c9cc1109e961e637/ocf_datapipes/config/model.py#L234-L243 that checks which provider the PV data is from in the config, this fails when not one of those ones listed here: https://github.com/openclimatefix/nowcasting_datamodel/blob/8fcc3ae61b50ca30815b910d9db2621ae6b2c33e/nowcasting_datamodel/models/pv.py#L20-L22

I could remove the check if we want? Would reduce dependencies and probably be fine

jacobbieker commented 8 months ago

I think for now, disabling the validator should work fine. We can always re-enable it if we want, or change how it works if we are splitting the datamodel into different repos for different regions/etc.

peterdudfield commented 8 months ago

Also if you are just importing those strings? you could move then to datapipes this means you can be more flexible and add more providers more easily

jacobbieker commented 8 months ago

Yeah, that might be the best way, I can do that

peterdudfield commented 8 months ago

Note we could also use pv-site-datamodel and expand this to wind-and-pv-site-datamodel. We would have to add a columns fo the site like:

But this might save us a lot of duplicate code. @devsjc would be interested in your opinion?

confusedmatrix commented 8 months ago

I think we should also add a country field to the SiteSQL model in pvsite-datamodel to make it easy to query the for India specific sites from the forecast app. Currently, there is region - but this is perhaps more specific than country-level.

peterdudfield commented 8 months ago

I think we should also add a country field to the SiteSQL model in pvsite-datamodel to make it easy to query the for India specific sites from the forecast app. Currently, there is region - but this is perhaps more specific than country-level.

yea lets do it, default to 'uk'