Remove fake NWP data - Githubissues

openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database

MIT License

1 stars 4 forks source link

Remove fake NWP data #23

Closed peterdudfield closed 6 months ago

peterdudfield commented 6 months ago

Detailed Description

The real NWP data is now there, so lets remove the fake data and the code assciaoted with it

Context

we added fake data in, due to not having live ECMWF data yet, but we do now

Possible Implementation

tidy up code here - https://github.com/openclimatefix/india-forecast-app/blob/main/india_forecast_app/models/pvnet/model.py#L127

peterdudfield commented 6 months ago

The NWP from s3 currentl has t2m, but it should be renamed to t as this is what Windnet wants. I think the palce to do it is here, not in the ocf_datapipes

peterdudfield commented 6 months ago

Context - https://github.com/openclimatefix/nwp-consumer/issues/127

peterdudfield commented 6 months ago

This might actually be easier to do this when processing the nwp data

peterdudfield commented 6 months ago

Sorry just to clear thingsup, the s3 data has 't' in it, but pvnet ML expected 't2m'. Am chaning it to expect 't'