search

openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database
MIT License
1 stars 4 forks source link

add logging #59

Closed peterdudfield closed 5 months ago

peterdudfield commented 5 months ago

Pull Request

Description

Ive added some logging.

Im not convinced the smoothing was working

Screenshot 2024-04-05 at 11 40 47

I think the best way is to run the forecast locally and see these values, The first value does not seem to be at 80% of the values

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

jacobbieker commented 5 months ago

example example example

Running in the tests with some examples, the code seems to be doing it correctly I think, at least that logic is. For what happened last night, looking into it now

jacobbieker commented 5 months ago

Oh, actually, https://github.com/openclimatefix/india-forecast-app/blob/f91aa67c86406f40458917250ee0c7b0a35c6890/india_forecast_app/app.py#L112 converts the database KW values back into MW values, so for the smoothing, we need to convert back to KW from MW. Otherwise, this is why the generation drops so much, as it is moving it 80% of the way, but to 1/1000th of the plotted live generation

jacobbieker commented 5 months ago

I think this should have fixed the issue that appeared last night