search

openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database
MIT License
1 stars 4 forks source link

Add Pvnet 2 hours smoothing #60

Closed peterdudfield closed 5 months ago

peterdudfield commented 5 months ago

Detailed Description

Add Pvnet 2 hours smoothing

Context

Possible Implementation

similar - https://github.com/openclimatefix/india-forecast-app/blob/main/india_forecast_app/models/pvnet/model.py#L126

peterdudfield commented 5 months ago

@jacobbieker what do you think? Might be good for @dfulu to try this

jacobbieker commented 5 months ago

Yeah, we can, I have the same reservations about using it like with the wind one, but if we want it to look better, then sure

peterdudfield commented 5 months ago

Yeah, we can, I have the same reservations about using it like with the wind one, but if we want it to look better, then sure

I understand, but do you agree it improves the 0-2 hour forecast? How we display the forecast is perhaps more of a UI, UX question

jacobbieker commented 5 months ago

Yeah, it does also mean, since the smoothing overwrites the model's forecast, we don't have how well it actually does for the first two hours. But yeah, it does improve the forecast. Happy for @dfulu to do it, or I can

peterdudfield commented 5 months ago

Can @jacobbieker decide if you or @dfulu do this? Thanks