search

openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database
MIT License
1 stars 4 forks source link

Remove smoothing on soalr #71

Closed peterdudfield closed 3 months ago

peterdudfield commented 4 months ago

Last few days we have not had smoothing on solar, due to role back issues. The forecast looks a lot better.

This may effect #69

So we would have to role back #62 but keep it on wind

Screenshot 2024-05-07 at 06 15 20
vishalj0501 commented 4 months ago

Hi @peterdudfield, Can I try this issue?

peterdudfield commented 4 months ago

Yea sure

vishalj0501 commented 3 months ago

Hi, Can I please have more information on this? I am having some trouble replicating this repo locally.

peterdudfield commented 3 months ago

Its basically to role back #62, so smoothing only happens on the wind forecast

vishalj0501 commented 3 months ago

So, should the fix be like this: https://github.com/openclimatefix/india-forecast-app/blob/fdf296ae4fea9923e070c912e9125326eccc3f0b/india_forecast_app/models/pvnet/model.py#L126

And also I'm trying to run it locally, facing some issues with docker.build. So I can't the test the changes i've made..

peterdudfield commented 3 months ago

SOrry @vishalj0501, ive pushed this one forward as i needed it for production

vishalj0501 commented 3 months ago

Sure! @peterdudfield , Sorry for the late. I'll look into more issues across OCF repos. Thank You