openclimatefix / india-forecast-app

Runs wind and PV forecasts for India and saves to database

MIT License

2 stars 4 forks source link

adding time_gfs windnet model #84

Closed AUdaltsova closed 3 months ago

AUdaltsova commented 3 months ago

Pull Request

Description

Adding changes to deploy time_3res gfs model

Changed:

pvnet and ocf_datapipes versions (bumped to support time features)
HF model hash

Checklist:

[X] My code follows OCF's coding style guidelines
[X] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have checked my code and corrected any misspellings

peterdudfield commented 3 months ago

I suspect this error is coming from the "new features" not being in the model somehow

Screenshot 2024-08-06 at 22 58 55 , looks like you might have been on this already in https://github.com/openclimatefix/PVNet/pull/242

AUdaltsova commented 3 months ago

I suspect this error is coming from the "new features" not being in the model somehow

, looks like you might have been on this already in openclimatefix/PVNet#242

Yep I somehow managed to merge without them in forward, but on fix it's failing a test (quite weirdly? I've been debugging it for a while now and it looks a) unrelated b) like it should've tripped up in the previous commit if it was an issue, but anyway)