openclimatefix / metnet

PyTorch Implementation of Google Research's MetNet and MetNet-2

MIT License

231 stars 47 forks source link

CI success #64

Closed rahul-maurya11b closed 3 months ago

rahul-maurya11b commented 3 months ago

Pull Request

Description

Fixes #

There were 2 issues :

RuntimeError: mat1 and mat2 shapes cannot be multiplied (2x265728 and 606976x256) and

2 .KeyError: 'num_att_heads' I have made some changes in metnet_pv and metnet.py. By doing that workflows pass all the tests, but I tried to run the workflow on a forked repo but didn't work. I have tried it locally and it works. Please check if it's correct.

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] No

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x]I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

jacobbieker commented 3 months ago

If you are happy, I can merge it?

rahul-maurya11b commented 3 months ago

Yes sir , Thanks

peterdudfield commented 3 months ago

@all-contributors please add @rahul-maurya11b for test

allcontributors[bot] commented 3 months ago

@peterdudfield

I've put up a pull request to add @rahul-maurya11b! :tada: