search

openclimatefix / metnet

PyTorch Implementation of Google Research's MetNet and MetNet-2
MIT License
242 stars 50 forks source link

Fix tests #66

Open peterdudfield opened 5 months ago

peterdudfield commented 5 months ago

The CI tests are currently failing, it would be great to get these working again

jramosss commented 5 months ago

Hey there, i see that the last failing pipeline shows that ruff is failing, and i see there are tons of errors see here Is the pipeline expected to fail when not meeting this requirements, should the "real issue" be fix formatting or maybe loose the rules a little bit?

peterdudfield commented 4 months ago

yea, perhaps it is to fix the formatting. What do you think should be done? Fix formatting or loosen the rules?

jramosss commented 4 months ago

First of all maybe change the name of the issue to fix formatting issues. Then, definitely loosen the rules, unless the philosophy of the repo is to use docstring (maybe in core/big functions helps, but i don't think every function should have a docstring) I created a new one, see #67