openclimatefix / metnet

PyTorch Implementation of Google Research's MetNet and MetNet-2
MIT License
231 stars 47 forks source link

Fix formatting issues/loosen ruff rules #67

Open jramosss opened 5 days ago

jramosss commented 5 days ago

CI is failing because of the formatting, see We should both loose the rules and fix previous errors

peterdudfield commented 4 days ago

Thank you @jramosss for doing this

peterdudfield commented 4 days ago

im not sure we should loosen the rules. I wonder what is standard when releasing these models?

jramosss commented 1 day ago

It depends, i'm just thinking maybe marking docstrings as required for every function is a bit extreme for example

peterdudfield commented 14 hours ago

It depends, i'm just thinking maybe marking docstrings as required for every function is a bit extreme for example

how would you suggest loosening the rules?