search

openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

Remove normalization warning #115

Closed peterdudfield closed 1 year ago

peterdudfield commented 2 years ago

removing warning here, by just deleting the code

makes to much logging and is not useful

After merging, would be good to update api with the new datamodel version - https://github.com/openclimatefix/nowcasting_api

lucasc896 commented 2 years ago

Tried to push to the repo but don't have write access. Am I expected to fork the repo and fix there?

peterdudfield commented 2 years ago

hi @lucasc896 I can give you write access, or some people fork and then do a PR, what would you prefer?

Thanks for trying this out/

lucasc896 commented 1 year ago

Whichever works best for you guys. Keen to do more than this small task, so perhaps write access?

peterdudfield commented 1 year ago

Hi @lucasc896 . Great you can want to do more. Could we try with you doing a PR first, then we can give you write access (once ive set up some branch protection)? I hope this isnt blocking you, and really appreciate that you want to help - thanks

peterdudfield commented 1 year ago

sorry @lucasc896, I went ahead and did it as I was trying to debug something and these statements were annoying me

peterdudfield commented 1 year ago

@lucasc896 , this one is still available if you want it - https://github.com/openclimatefix/nowcasting_datamodel/issues/128

lucasc896 commented 1 year ago

Sorry @peterdudfield - it's been a hectic end to the year! Thanks for your suggestion 👍

peterdudfield commented 1 year ago

no worries @lucasc896 , thanks very much for doing this.