openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

Issue/metric time of day #149

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

add time_of_day to metric value table

Helps with https://github.com/openclimatefix/nowasting_metrics/issues/14

How Has This Been Tested?

CI tests

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #149 (32c54db) into main (57a1af5) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 32c54db differs from pull request most recent head 8a55b5c. Consider uploading reports for the commit 8a55b5c to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          21       21           
  Lines        1209     1210    +1     
=======================================
+ Hits         1159     1160    +1     
  Misses         50       50           
Impacted Files Coverage Δ
nowcasting_datamodel/models/metric.py 96.96% <100.00%> (+0.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more