openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project

6 stars 6 forks source link

update model id to use from forecast not forecast historic #164

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

Add migration instructions
fix for model id Fixes #

How Has This Been Tested?

Normal test,

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

codecov[bot] commented 1 year ago

Codecov Report

Merging #164 (7d0df19) into main (efa8ed1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files          23       23           
  Lines        1456     1456           
=======================================
  Hits         1381     1381           
  Misses         75       75

Impacted Files	Coverage Δ
nowcasting_datamodel/save/update.py	`99.00% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more