openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

add Optional in metric values #264

Closed peterdudfield closed 8 months ago

peterdudfield commented 8 months ago

Pull Request

Description

Allow Nonw for time_of_day

Fixes https://github.com/openclimatefix/uk-analysis-dashboard/issues/110

How Has This Been Tested?

Ran analysis dashbaord locally

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.31%. Comparing base (4ae9dc2) to head (d13163b). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ======================================= Coverage 95.31% 95.31% ======================================= Files 27 27 Lines 1770 1770 ======================================= Hits 1687 1687 Misses 83 83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.