openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

Removed blend present in uk-pv-forecast-blend #265

Closed roshnaeem closed 8 months ago

roshnaeem commented 8 months ago

Pull Request

Description

Removed the duplicated blend files + tests files present in uk-pv-forecast-blend

Fixes #248

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

roshnaeem commented 8 months ago

@peterdudfield , i think this PR will also close #226

peterdudfield commented 8 months ago

Have you run pytest on this?

roshnaeem commented 8 months ago

Hello @peterdudfield, I ran the pytest command in the directory to run the pytests. It showed the same errors after changes as it was showing before making any changes. Without changes, it showed me 140, and after changes, it showed me 126 errors.

Without changes:

Screenshot 2024-03-11 at 5 27 30 PM

With changes:

Screenshot 2024-03-11 at 5 27 11 PM
peterdudfield commented 8 months ago

Thank you, ill merge it to development to check tests