search

openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

pydantic: Upgrade validator to field_validator #281

Closed peterdudfield closed 5 months ago

peterdudfield commented 5 months ago

Similar to https://github.com/openclimatefix/ocf_datapipes/issues/318

Upgrade current validators to field_validators

https://stackoverflow.com/questions/76734333/pydantic-v2-field-validator-values-argument-equivalent

Bvr4 commented 5 months ago

Hello, I might be interested in contributing to your project by taking charge of this issue. Can it be assigned to me?

Plomo-02 commented 5 months ago

hello, can I be assigned to this issue?

Bvr4 commented 5 months ago

Hello, while working on this issue, I read the pydantic migration guide and saw that the from_orm method is deprecated. I have seen this method in some models. Perhaps this could be the subject of a new issue?

peterdudfield commented 5 months ago

yes pelase, could you make a new issue for this? Thanks