openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

Gsp nans #32

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Pull Request

Description

Fixes https://github.com/openclimatefix/GSPConsumer/issues/10

How Has This Been Tested?

added a unittest test to check nan is filtered

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #32 (9fa320b) into main (0590438) will increase coverage by 0.34%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   97.90%   98.24%   +0.34%     
==========================================
  Files          16       16              
  Lines         572      570       -2     
==========================================
  Hits          560      560              
+ Misses         12       10       -2     
Impacted Files Coverage Δ
nowcasting_datamodel/models/gsp.py 93.44% <100.00%> (+2.67%) :arrow_up:
nowcasting_datamodel/read/read_gsp.py 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more