openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

Issue/pv read #36

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Pull Request

Description

add read function for pv yields add tests

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #36 (5c48cdd) into main (40cd43c) will decrease coverage by 0.10%. The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   97.92%   97.81%   -0.11%     
==========================================
  Files          16       16              
  Lines         577      595      +18     
==========================================
+ Hits          565      582      +17     
- Misses         12       13       +1     
Impacted Files Coverage Δ
nowcasting_datamodel/read/read_pv.py 98.18% <94.44%> (-1.82%) :arrow_down:
nowcasting_datamodel/__init__.py 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more