openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

make gsp_id column unique #45

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Pull Request

Description

Make gsp id columns in LocationSQL distinct

Fixes #44

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #45 (884954a) into main (04815bc) will increase coverage by 0.04%. The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   98.33%   98.37%   +0.04%     
==========================================
  Files          16       16              
  Lines         602      617      +15     
==========================================
+ Hits          592      607      +15     
  Misses         10       10              
Impacted Files Coverage Δ
nowcasting_datamodel/read/read.py 99.23% <90.00%> (+0.06%) :arrow_up:
nowcasting_datamodel/__init__.py 100.00% <100.00%> (ø)
nowcasting_datamodel/fake.py 100.00% <100.00%> (ø)
nowcasting_datamodel/models/gsp.py 93.65% <100.00%> (+0.20%) :arrow_up:
nowcasting_datamodel/national.py 92.10% <100.00%> (+0.67%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more