openclimatefix / nowcasting_datamodel

Datamodel for the nowcasting project
6 stars 6 forks source link

Issue/forecast horizon #91

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Pull Request

Description

move read forecast horizon to differnt read function, (last read function would not have worked)

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #91 (4a3773b) into main (f21fae2) will decrease coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 4a3773b differs from pull request most recent head cad1487. Consider uploading reports for the commit cad1487 to get more accurate results

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   98.54%   98.53%   -0.01%     
==========================================
  Files          17       17              
  Lines         822      820       -2     
==========================================
- Hits          810      808       -2     
  Misses         12       12              
Impacted Files Coverage Δ
nowcasting_datamodel/read/read.py 98.95% <100.00%> (-0.02%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more