openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data
https://nowcasting-dataset.readthedocs.io/en/stable/
MIT License
25 stars 6 forks source link

After `rioxarray` 1.3 is released, remove `OpenData` from `TopographicDataSource.__post_init__()` #385

Open JackKelly opened 2 years ago

JackKelly commented 2 years ago

Right now, rioxarray can't open data directly from cloud storage buckets, so TopographicDataSource.__post_init__() downloads files to the VM's local hard disk using OpenData. But rioxarray v1.3 will enable rioxarray to open directly from cloud storage buckets, so we can remove OpenData from TopographicDataSource.__post_init__()

See https://github.com/corteva/rioxarray/issues/246#issuecomment-968515945

peterdudfield commented 2 years ago

Good spot, and nice to always reduce our codebase

peterdudfield commented 2 years ago

Itll be ' rasterio 1.3' which is near out ...