Remove unused consts - Githubissues

openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data

MIT License

25 stars 6 forks source link

Closed JackKelly closed 2 years ago

JackKelly commented 2 years ago

Possibly remove these from consts.py and grep -r --include=*.py through the code to find other uses of these consts:

lenassero commented 2 years ago

Hi Jack!

I could tackle this little first issue !

For the mentioned variables:

BUCKET, PV_PATH an PV_FILENAME and PV_METADATA_FILENAME are not imported anywhere inside nowcasting_dataset(they are usually redefined in the different notebooks or scripts)
NWP_FILENAME is never used either
SAT_FILENAME however seems to be used in two places: here and here

JackKelly commented 2 years ago

Great work! Thanks so much for diving in!

Please do go ahead and delete BUCKET, PV_PATH, PV_FILENAME, PV_METADATA_FILENAME, and NWP_FILENAME!

And maybe we should create a new issue specifically to remove SAT_FILENAME.

peterdudfield commented 2 years ago

Thanks @lenassero for this work - ill keep this issue open until a new issue is made for SAT_FILENAME

peterdudfield commented 2 years ago

@all-contributors please add @lenassero for code

allcontributors[bot] commented 2 years ago

@peterdudfield

I've put up a pull request to add @lenassero! :tada: