search

openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data
https://nowcasting-dataset.readthedocs.io/en/stable/
MIT License
24 stars 6 forks source link

remove zarr from nwp filename #582

Open peterdudfield opened 2 years ago

peterdudfield commented 2 years ago

Detailed Description

Currently the nwp filename is 'nwp_zarr_path' but it in fact can be a 'netcdf' file once this PR (#581) has happened The pydantic model file is here

Context

Good to have variable names

Possible Implementation

change to 'nwp_path' instead?

JackKelly commented 2 years ago

nwp_path sounds good to me!

Maybe we should change all the _zarr_path attributes (e.g. also change satellite_zarr_path to just satellite_path) to be consistent across DataSources?