Open JackKelly opened 2 years ago
Why does it matter if its normalised or not?
Here's the code (nowcasting_dataset/data_sources/pv/pv_data_source.py
):
Note that the threshold (defined on line 546) is a "normalised" threshold. If the PV power isn't normalised, then the threshold is way too low to have much effect!
I'm pretty confident this is a "real" bug :slightly_smiling_face:
ah i forgot about the threshold - thanks
Describe the bug
nowcasting_dataset.data_sources.pv.pv_data_source.drop_pv_systems_which_produce_overnight
expected power values to be normalised. But, whendrop_pv_systems_which_produce_overnight
is called, it is given raw un-normalised power values.