search

openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data
https://nowcasting-dataset.readthedocs.io/en/stable/
MIT License
24 stars 6 forks source link

`hrv_satellite_fake` should return the requested `image_size_pixels`, not `3 x image_size_pixels` #693

Closed JackKelly closed 2 years ago

JackKelly commented 2 years ago

Describe the bug If you ask hrv_satellite_fake for an image 256 pixels wide by 128 pixels high then it'll return an image of shape 768 wide x 384 high.

Which, presumably, is because of the * 3 on lines 376 & 377 of batch.py:

image

@peterdudfield is it safe to simply remove the * 3 from those lines? :slightly_smiling_face:

Yes, the HRV images are higher resolution than the other satellite channels. But the configuration requests the image size in pixels, so, if I've understood correctly, the HRV images should always be exactly the pixel sizes that were requested in the config?

peterdudfield commented 2 years ago

Yea, you can remove the *3. Sorry about that

JackKelly commented 2 years ago

No worries at all! I'll submit a PR in a few mins :slightly_smiling_face: