Fake `hrvsatellite` and `satellite` batches need 2D osgb coords

openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data

https://nowcasting-dataset.readthedocs.io/en/stable/

MIT License

24 stars 6 forks source link

Fake `hrvsatellite` and `satellite` batches need 2D osgb coords #695

Closed JackKelly closed 2 years ago

JackKelly commented 2 years ago

At the moment, nowcasting_dataset.data_sources.fake.batch.create_image_array creates fake satellite data with 1D x_geostationary and y_geostationary coords. We also need 2D x_osgb and y_osgb coords.

I just wanted to check with you, @peterdudfield, that this change won't break too many things?!

peterdudfield commented 2 years ago

If thats the way the new batch is then we should use that. When we generate batches are they in 2D?

JackKelly commented 2 years ago

When we generate batches are they in 2D?

Yes, the pre-prepared batches on disk (created by prepare_ml_data.py) have 2D OSGB coords.