openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data
https://nowcasting-dataset.readthedocs.io/en/stable/
MIT License
25 stars 6 forks source link

2D osgb sat coords #700

Closed JackKelly closed 2 years ago

JackKelly commented 2 years ago

Pull Request

This is the correct PR for this issue!

Description

Give fake hrv batches 2D osgb coords. Because "real" satellite data has 2D osgb coords.

Fixes #695

How Has This Been Tested?

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #700 (14b9f96) into jack/tidy_fake_coordinates (74f9a20) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@                      Coverage Diff                       @@
##           jack/tidy_fake_coordinates     #700      +/-   ##
==============================================================
+ Coverage                       93.24%   93.26%   +0.01%     
==============================================================
  Files                              48       48              
  Lines                            3391     3401      +10     
==============================================================
+ Hits                             3162     3172      +10     
  Misses                            229      229              
Impacted Files Coverage Δ
nowcasting_dataset/data_sources/fake/batch.py 86.97% <100.00%> (+0.30%) :arrow_up:
...owcasting_dataset/data_sources/fake/coordinates.py 91.66% <100.00%> (+1.04%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more