openclimatefix / nowcasting_dataset

Prepare batches of data for training machine learning solar electricity nowcasting data
https://nowcasting-dataset.readthedocs.io/en/stable/
MIT License
24 stars 6 forks source link

get gsp list from pvlive, not url #714

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

update to use pvlive to load gsp metadata

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #714 (43ea8f0) into main (cfecf83) will increase coverage by 0.04%. The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
+ Coverage   92.86%   92.91%   +0.04%     
==========================================
  Files          48       48              
  Lines        3463     3458       -5     
==========================================
- Hits         3216     3213       -3     
+ Misses        247      245       -2     
Impacted Files Coverage Δ
nowcasting_dataset/manager/manager.py 99.37% <ø> (ø)
nowcasting_dataset/data_sources/gsp/eso.py 67.12% <50.00%> (-1.01%) :arrow_down:
nowcasting_dataset/data_sources/gsp/pvlive.py 95.52% <80.00%> (-4.48%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more