openclimatefix / nowcasting_forecast

Making live forecasts for the nowcasting project
MIT License
5 stars 2 forks source link

Strange results for CNN model #81

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

When first running the model we get some odd results. Often the predictions are negative

select * from forecast
join forecast_value on forecast.id = forecast_value.forecast_id
join location on location_id = location.id
join model on model_id = model.id
where model.name  = 'cnn'
and gsp_id = 1
Screenshot 2022-05-17 at 15 05 34
jacobbieker commented 2 years ago
peterdudfield commented 2 years ago

We think we've sovled it

https://github.com/openclimatefix/nowcasting_forecast/blob/main/nowcasting_forecast/models/utils.py#L244

model.load_model(use_hf=use_hf).eval()

should be

model = model.load_model(use_hf=use_hf).eval()