openclimatefix / nowcasting_utils

Common functionality between SatFlow and predict_pv_yield
https://nowcasting-utils.readthedocs.io/en/stable/
MIT License
3 stars 0 forks source link

fix loss for batches examples #76

Closed peterdudfield closed 2 years ago

peterdudfield commented 2 years ago

Pull Request

Description

fix losses, so that don't add up over batches

Fixes #

How Has This Been Tested?

unittests (added new ones)

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #76 (38b3d02) into main (ed4fe3b) will increase coverage by 0.03%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   78.49%   78.53%   +0.03%     
==========================================
  Files          21       21              
  Lines        1074     1076       +2     
==========================================
+ Hits          843      845       +2     
  Misses        231      231              
Impacted Files Coverage Δ
nowcasting_utils/visualization/visualization.py 86.20% <66.66%> (ø)
nowcasting_utils/models/loss.py 83.95% <100.00%> (+0.40%) :arrow_up:
nowcasting_utils/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cea03e0...38b3d02. Read the comment docs.