openclimatefix / ocf-infrastructure

Infrastructure code for OCF's cloud environments
3 stars 6 forks source link

rm docker_version from modules/services/pv/variables.tf and nowcasting/development/main.tf and production #455

Closed aryanbhosale closed 6 months ago

aryanbhosale commented 6 months ago

Pull Request

Description

Please delete the italicised instruction text! Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #375

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

peterdudfield commented 6 months ago

@devsjc you could always merge this to a internal branch and then make a PR, to see that CI tests work? Im not suer how else to trigger it?

devsjc commented 6 months ago

Since this is so small I'm tempted just to merge it anyway, can always revert if something goes wrong somehow!

BreakingPitt commented 6 months ago

@peterdudfield This is still open? Not merged? Needs to work on it?