openclimatefix / ocf-infrastructure

Infrastructure code for OCF's cloud environments

3 stars 6 forks source link

chore: renaming nwp service to include metoffice #476

Closed aatmanvaidya closed 6 months ago

aatmanvaidya commented 6 months ago

Pull Request

Description

This PR resolves https://github.com/openclimatefix/ocf-infrastructure/issues/469 In the nowcasting/development/main.tf file, I have made changes to the nwp-national and data-national service as instructed in the issue

Fixes #

How Has This Been Tested?

I was not able to terraform validate to run the tests, if possible can someone guide me a bit more on how to run the tests

[ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[ ] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

peterdudfield commented 6 months ago

Thanks, Im gona merge it to development, and then get the CI tests to run