openclimatefix / ocf-infrastructure

Infrastructure code for OCF's cloud environments
3 stars 6 forks source link

analysis dashboard access to satellite bucket #482

Closed aryanbhosale closed 5 months ago

aryanbhosale commented 5 months ago

Pull Request

Description

Please delete the italicised instruction text! Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

peterdudfield commented 5 months ago
Screenshot 2024-03-17 at 20 34 24

I get this error

peterdudfield commented 5 months ago

Do you need to remove this one - https://github.com/openclimatefix/ocf-infrastructure/blob/external-pr/terraform/modules/services/eb_app/iam.tf#L128

aryanbhosale commented 5 months ago

Do you need to remove this one - https://github.com/openclimatefix/ocf-infrastructure/blob/external-pr/terraform/modules/services/eb_app/iam.tf#L128

Yes, ill make the change , thank you for pointing it out

aryanbhosale commented 5 months ago

Do you need to remove this one - https://github.com/openclimatefix/ocf-infrastructure/blob/external-pr/terraform/modules/services/eb_app/iam.tf#L128

I have removed this