search

openclimatefix / ocf-infrastructure

Infrastructure code for OCF's cloud environments
3 stars 6 forks source link

analysis dashboard access to satellite bucket (#482) #486

Closed peterdudfield closed 4 months ago

peterdudfield commented 5 months ago

Pull Request

Description

Please delete the italicised instruction text! Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

Checklist:

aryanbhosale commented 4 months ago
  • added var s3_nwp_buckets
  • analysis dashboard access to satellite bucket
  • added variables.tfvars
  • Refactor: Modify s3_nwp_bucket variable to accept a list of bucket ARNs
  • updated modules in india/dev & nowcasting/dev to include the new list of s3_nwp_buckets

Pull Request

Description

Please delete the italicised instruction text! Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • [ ] Yes

Checklist:

  • [ ] My code follows OCF's coding style guidelines
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have checked my code and corrected any misspellings

hi @peterdudfield , is there anything that needs to be added here? or is it good to be merged?

peterdudfield commented 4 months ago

can you resolved conflicts?

aryanbhosale commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

aryanbhosale commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

should i open a pr from main to this branch and merge it that way?

aryanbhosale commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

should i open a pr from main to this branch and merge it that way?

or should i just add the changes ive made in these 5 files to the main one, thatll be faster in my opinion. what do you think @peterdudfield ?

peterdudfield commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

should i open a pr from main to this branch and merge it that way?

or should i just add the changes ive made in these 5 files to the main one, thatll be faster in my opinion. what do you think @peterdudfield ?

On this PR, I think its good to resolve conflicts, theres a button in the Github that should do this, or you can do it locally.

aryanbhosale commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

should i open a pr from main to this branch and merge it that way?

or should i just add the changes ive made in these 5 files to the main one, thatll be faster in my opinion. what do you think @peterdudfield ?

On this PR, I think its good to resolve conflicts, theres a button in the Github that should do this, or you can do it locally.

I think the button is visible to the creator of the pr, I think we need to create another pr from main(which is ahead by 25/26 commits)to external-pr(this branch) , and there we'll see what's missing/conflicting, should I do that?

peterdudfield commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

should i open a pr from main to this branch and merge it that way?

or should i just add the changes ive made in these 5 files to the main one, thatll be faster in my opinion. what do you think @peterdudfield ?

On this PR, I think its good to resolve conflicts, theres a button in the Github that should do this, or you can do it locally.

Thanks, ive merge this, but I think there is still something missing.

need to add the satellite read policy to the analysis dashboard?, So adding this policy to here

aryanbhosale commented 4 months ago

can you resolved conflicts?

where do i check the conflicts?

should i open a pr from main to this branch and merge it that way?

or should i just add the changes ive made in these 5 files to the main one, thatll be faster in my opinion. what do you think @peterdudfield ?

On this PR, I think its good to resolve conflicts, theres a button in the Github that should do this, or you can do it locally.

Thanks, ive merge this, but I think there is still something missing.

need to add the satellite read policy to the analysis dashboard?, So adding this policy to here

What do you think could be added?

peterdudfield commented 4 months ago

Its the policy to read the satellite bucket, so that the analysis dashboard has access to it