openclimatefix / ocf-infrastructure

Infrastructure code for OCF's cloud environments

3 stars 6 forks source link

Remove region from task definition #546

Closed BreakingPitt closed 4 months ago

BreakingPitt commented 4 months ago

Pull Request

Description

As requested in #541 remove the region from task definition in dayafter-dag.py

Fixes #541

Checklist:

[X] My code follows OCF's coding style guidelines
[X] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

BreakingPitt commented 4 months ago

@peterdudfield Sorry for the confusion, I misunderstood the objective of the change and thought I needed to remove the region throughout the entire file instead of just in the specific task definition. I've just corrected it and revert the unnecessary changes.

Can you review it to see if it is right?

Best regards

peterdudfield commented 4 months ago

Thanks @BreakingPitt Ive done this now in https://github.com/openclimatefix/ocf-infrastructure/pull/556, so Ill close this PR if thats ok. Thank you for your help