openclimatefix / ocf_datapipes

OCF's DataPipe based dataloader for training and inference
MIT License
13 stars 11 forks source link

Issue/pvnet #124

Closed peterdudfield closed 1 year ago

peterdudfield commented 1 year ago

Pull Request

Description

Fixes #

How Has This Been Tested?

CI tests

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #124 (c0561b0) into main (f8792c6) will increase coverage by 2.32%. The diff coverage is 82.83%.

:exclamation: Current head c0561b0 differs from pull request most recent head f184da8. Consider uploading reports for the commit f184da8 to get more accurate results

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   77.87%   80.20%   +2.32%     
==========================================
  Files         124      118       -6     
  Lines        5094     4738     -356     
==========================================
- Hits         3967     3800     -167     
+ Misses       1127      938     -189     
Impacted Files Coverage Δ
ocf_datapipes/training/datamodules/default.py 0.00% <0.00%> (ø)
ocf_datapipes/convert/numpy/pv.py 37.50% <9.09%> (+1.13%) :arrow_up:
ocf_datapipes/convert/numpy/gsp.py 86.36% <62.50%> (+1.36%) :arrow_up:
ocf_datapipes/select/select_spatial_slice.py 80.00% <63.46%> (+1.11%) :arrow_up:
ocf_datapipes/training/nwp_pv.py 87.93% <75.00%> (-1.36%) :arrow_down:
ocf_datapipes/load/configuration.py 95.45% <87.50%> (-4.55%) :arrow_down:
...cf_datapipes/transform/numpy/batch/sun_position.py 95.65% <93.87%> (+0.12%) :arrow_up:
ocf_datapipes/batch/fake/gsp.py 100.00% <100.00%> (ø)
ocf_datapipes/batch/fake/sun.py 100.00% <100.00%> (ø)
...f_datapipes/batch/merge_numpy_examples_to_batch.py 100.00% <100.00%> (+5.26%) :arrow_up:
... and 15 more

... and 34 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jacobbieker commented 1 year ago

@dfulu This might be good to look at to.