openclimatefix / ocf_datapipes

OCF's DataPipe based dataloader for training and inference
MIT License
13 stars 11 forks source link

fix constants file, bump pre-commit isort #152

Closed thomasarmstrong98 closed 1 year ago

thomasarmstrong98 commented 1 year ago

Pull Request

Description

After recent PR, file ocf_datapipes/utils/consts.py wasn't working due to small bug where dataarray creation took the superset of all variables instead of only those passed through as keys in the dictionary. Fixed this and tested working.

Also, bumping the pre-commit isort version to 5.12.0, as there are errors on the current version (see new thread https://stackoverflow.com/questions/75269700/pre-commit-fails-to-install-isort-5-11-4-with-error-runtimeerror-the-poetry-co). Upgrading the isort pre-commit config fixed this issue.

Fixes #

How Has This Been Tested?

Debugged change in ocf_datapipes/utils/consts.py

Checklist:

peterdudfield commented 1 year ago

First error starting happening here- https://github.com/openclimatefix/ocf_datapipes/actions/runs/4173316355/jobs/7225498026