Fix GSP multi-region merging - Githubissues

openclimatefix / ocf_datapipes

OCF's DataPipe based dataloader for training and inference

MIT License

13 stars 11 forks source link

Fix GSP multi-region merging #188

Closed dfulu closed 1 year ago

dfulu commented 1 year ago

Fixes issue #187

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

[x] Yes

All shapes before - (note that here I just plot the sum of all the polygons)

download (4)

All shapes after - (note here I plot all the polygons individually)

download (3)

Checklist:

[ ] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and corrected any misspellings

JackKelly commented 1 year ago

To give some more context, and to highlight just how important this fix is, @dfulu says:

[the bug] messed up alignment for every GSP after the first duplicated one. Which was the 5th one. So pretty much them all, yeh. And since the GSPs are given an ID which is sorted by alphabetically by their code thing (like "AXMI1") the satallite/NWP image could be a completely different part of the country.