search

openclimatefix / ocf_datapipes

OCF's DataPipe based dataloader for training and inference
MIT License
13 stars 11 forks source link

Fix coord search #232

Closed dfulu closed 10 months ago

dfulu commented 10 months ago

Pull Request

Description

Fix how we search for coords to limit to "dimension coordinates"

This is an edge case for where multiple of the searched for spatial coordinates exist in the xarray object, but some are non-dimension coordinates

codecov[bot] commented 10 months ago

Codecov Report

Merging #232 (e517767) into main (2c39650) will decrease coverage by 0.01%. Report is 17 commits behind head on main. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   80.11%   80.10%   -0.01%     
==========================================
  Files         127      127              
  Lines        5611     5620       +9     
==========================================
+ Hits         4495     4502       +7     
- Misses       1116     1118       +2
Files Coverage Δ
ocf_datapipes/utils/geospatial.py 79.31% <88.88%> (+3.66%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more