openclimatefix / ocf_datapipes

OCF's DataPipe based dataloader for training and inference
MIT License
13 stars 11 forks source link

Add Updated NaN Checks #236

Closed jacobbieker closed 10 months ago

jacobbieker commented 10 months ago

Pull Request

Description

This PR updates the NaN checking to be more informative and give warnings rather than errors.

Fixes #

How Has This Been Tested?

Unit tests

Checklist:

codecov[bot] commented 10 months ago

Codecov Report

Merging #236 (7e9bcfa) into main (2d22c80) will increase coverage by 0.26%. Report is 11 commits behind head on main. The diff coverage is 46.42%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   80.18%   80.45%   +0.26%     
==========================================
  Files         127      128       +1     
  Lines        5622     5633      +11     
==========================================
+ Hits         4508     4532      +24     
+ Misses       1114     1101      -13     
Files Coverage Δ
ocf_datapipes/training/example/nwp_pv.py 89.28% <100.00%> (ø)
ocf_datapipes/utils/geospatial.py 79.31% <75.00%> (ø)
ocf_datapipes/visualization/batch.py 0.00% <0.00%> (ø)
ocf_datapipes/validation/check_for_nans.py 78.37% <61.90%> (-12.54%) :arrow_down:
ocf_datapipes/validation/check_equality.py 70.14% <31.03%> (+34.08%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

dfulu commented 10 months ago

Looks good. Just one wee comment