Closed jacobbieker closed 6 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
e86aabf
) 77.51% compared to head (0972bb7
) 77.99%.
Files | Patch % | Lines |
---|---|---|
ocf_datapipes/load/wind/utils.py | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! Yeah, for the failing test, in discussion here https://github.com/openclimatefix/india-forecast-app/issues/2 as to what to do about it, as its from nowcasting_datamodel's check of PV data
Could you keep the validator there for PV, but not for Wind?
The validator isn't running for Wind, but is for PV. We can add it back for PV, but we probably should put the definition of the names in datapipes, not in datamodel. As of right now, the validator validates passiv and pvoutput.org from nowcasting_datamodels, and adds SV here. So I can re-add it, but would like to remove the dependency on nowcasting_datamodel
The validator isn't running for Wind, but is for PV. We can add it back for PV, but we probably should put the definition of the names in datapipes, not in datamodel. As of right now, the validator validates passiv and pvoutput.org from nowcasting_datamodels, and adds SV here. So I can re-add it, but would like to remove the dependency on nowcasting_datamodel
I agree, yea nice
Pull Request
Description
Adds loading wind power, such as for India. Also adds a test for loading India PV power
Fixes #
How Has This Been Tested?
Unit Tests
Checklist: